Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - test ELFs #604

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Cleanup - test ELFs #604

merged 5 commits into from
Oct 7, 2024

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Oct 7, 2024

  • SBPF v2 ELF relocation tests must be removed as relocation itself will be removed
  • SBPF v2 ELF static syscall execution tests must be removed because unresolved syscalls will become a verification error
  • Marks and recompiles all other test ELFs as SBPF v1

New SBPF v2 ELFs will be added back in the upcoming changes to the call opcodes and strict ELF loader.

@Lichtso Lichtso force-pushed the cleanup/test_elfs branch from 02d945b to 7b758a2 Compare October 7, 2024 14:14
@Lichtso Lichtso force-pushed the cleanup/test_elfs branch from 7b758a2 to 1f99756 Compare October 7, 2024 17:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (1223789) to head (1f99756).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   90.09%   89.59%   -0.51%     
==========================================
  Files          22       22              
  Lines        9726     9790      +64     
==========================================
+ Hits         8763     8771       +8     
- Misses        963     1019      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lichtso Lichtso force-pushed the cleanup/test_elfs branch from 1f99756 to 4c51521 Compare October 7, 2024 17:23
@Lichtso Lichtso force-pushed the cleanup/test_elfs branch from 4c51521 to 8b81e33 Compare October 7, 2024 17:32
@Lichtso Lichtso requested a review from LucasSte October 7, 2024 17:46
@Lichtso Lichtso marked this pull request as ready for review October 7, 2024 17:46
@Lichtso Lichtso merged commit c06f051 into main Oct 7, 2024
12 checks passed
@Lichtso Lichtso deleted the cleanup/test_elfs branch October 7, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants